[
https://issues.apache.org/jira/browse/MAPREDUCE-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636143#comment-14636143
]
Allen Wittenauer commented on MAPREDUCE-6415:
---------------------------------------------
Here's what shellcheck had to say about the generated bash:
{code}
In /tmp/1 line 4:
CONTAINER_ID_NUM=`echo $CONTAINER_ID | cut -d "_" -f 5`
^-- SC2006: Use $(..) instead of legacy `..`.
^-- SC2086: Double quote to prevent globbing and word
splitting.
In /tmp/1 line 25:
$HADOOP_HOME/bin/hadoop archive -Dmapreduce.framework.name=local -archiveName
$appId.har -p /tmp/logs/$user/logs/$appId \* /tmp/logs/archive-logs-work
^-- SC2086: Double quote to prevent globbing and word splitting.
In /tmp/1 line 26:
$HADOOP_HOME/bin/hadoop fs -mv /tmp/logs/archive-logs-work/$appId.har
/tmp/logs/$user/logs/$appId/$appId.har
^-- SC2086: Double quote to prevent globbing and word splitting.
In /tmp/1 line 27:
originalLogs=`$HADOOP_HOME/bin/hadoop fs -ls /tmp/logs/$user/logs/$appId | grep
"^-" | awk '{print $8}'`
^-- SC2006: Use $(..) instead of legacy `..`.
^-- SC2086: Double quote to prevent globbing and word splitting.
In /tmp/1 line 29:
$HADOOP_HOME/bin/hadoop fs -rm $originalLogs
^-- SC2086: Double quote to prevent globbing and word splitting.
^-- SC2086: Double quote to prevent
globbing and word splitting.
{code}
> Create a tool to combine aggregated logs into HAR files
> -------------------------------------------------------
>
> Key: MAPREDUCE-6415
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6415
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Affects Versions: 2.8.0
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: HAR-ableAggregatedLogs_v1.pdf,
> MAPREDUCE-6415_branch-2_prelim_001.patch, MAPREDUCE-6415_prelim_001.patch
>
>
> While we wait for YARN-2942 to become viable, it would still be great to
> improve the aggregated logs problem. We can write a tool that combines
> aggregated log files into a single HAR file per application, which should
> solve the too many files and too many blocks problems. See the design
> document for details.
> See YARN-2942 for more context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
