[
https://issues.apache.org/jira/browse/MAPREDUCE-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143609#comment-15143609
]
Robert Kanter commented on MAPREDUCE-6627:
------------------------------------------
Thanks for the review. I'll start working on the more straightforward ones,
but here's some that I either had questions on or wanted to clarify:
- FindBugs actually suggested I catch the {{RuntimeException}} and rethrow it
like that. The idea is to handle {{Exception}} without accidentally catching
{{RuntimeExeption}}. See
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6311/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html#REC_CATCH_EXCEPTION
That said, we're just wrapping {{Exception}} and not really handling it
anyway, so I'll revisit this.
- Where are you referring to exactly on this?
{quote}On a philosophical note, I don't like the if x then return idiom. I'd
rather have the code wrapped in an if !x.{quote}
- You're right that the comparators are a bit confusing. I didn't write them
originally, but now that I'm moving them I'll take the opportunity to rewrite
them for clarity.
- I originally had {{JobHistoryViewerPrinter}} as an abstract class because it
had some common methods in it that both Printer implementations used, but I had
since refactored that a lot, so there's no more common code and never changed
it. Good catch; I'll make this in an interface.
> Add machine-readable output to mapred job -history command
> ----------------------------------------------------------
>
> Key: MAPREDUCE-6627
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6627
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 2.9.0
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: MAPREDUCE-6627.001.patch, MAPREDUCE-6627.002.patch,
> json.txt, json_all.txt
>
>
> It would be great if we could add a machine-readable output format, say JSON,
> to the {{mapred job -history \[all\] <jobHistoryFile>}} command so that it's
> easier for programs to consume that information and do further processing on
> it. At the same time, we should keep the existing API and formatting intact
> for backwards compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
