[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151488#comment-15151488
 ] 

Karthik Kambatla commented on MAPREDUCE-6627:
---------------------------------------------

Thanks for working on this, Robert.

The v5 patch looks generally good barring these nits:
# Rename the subclasses of JobHistoryViewerPrinter, may be to 
HumanReadableViewerPrinter and JsonViewerPrinter or something else? The current 
naming uses Human and JSON between Viewer and Printer and hence a little 
confusing. 
# This is not introduced in this patch, but the command-line parsing in the CLI 
looks very complicated. May be there is value in revisiting this and use a 
CLI-parsing library for simplicity, probably in a follow up JIRA?
# For the CLI changes in this patch, I was wondering if it would make sense to 
add methods getOutputFile, getFormat etc. to see if those options are 
specified. For example, it appears the ordering of the options is to 
maintained. If one specifies "-format" before "-outfile", the latter wouldn't 
be parsed. 

> Add machine-readable output to mapred job -history command
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-6627
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6627
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.9.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: MAPREDUCE-6627.001.patch, MAPREDUCE-6627.002.patch, 
> MAPREDUCE-6627.003.patch, MAPREDUCE-6627.004.patch, MAPREDUCE-6627.005.patch, 
> json.txt, json_all.txt
>
>
> It would be great if we could add a machine-readable output format, say JSON, 
> to the {{mapred job -history \[all\] <jobHistoryFile>}} command so that it's 
> easier for programs to consume that information and do further processing on 
> it.  At the same time, we should keep the existing API and formatting intact 
> for backwards compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to