[
https://issues.apache.org/jira/browse/MAPREDUCE-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267638#comment-15267638
]
Sangjin Lee commented on MAPREDUCE-6688:
----------------------------------------
Agreeing with [~gtCarrera9], I'd like to propose that we proceed with the
version without refactoring for now. What do others think?
I took a look at that patch (v.2.01), and had a few comments.
(JobHistoryEventHandler.java)
- l.1129-1130: The id and type are set twice (once in {{createJobEntity()}},
another here). I think these second set calls should be removed.
- l.1140-1145: if a single key/value exceeds the limit, it will do a spurious
{{putEntities()}} call with empty entities unnecessarily; I think there should
be an additional check to see if there is anything to send
Did we reach a conclusion on whether these should be {{putEntities()}}
(blocking) or {{putEntitiesAsync()}}? I'm leaning slightly towards the blocking
call, as the config is arguably more important information than periodic metric
updates for example. I don't think we have established a firm rule on what
should be sync and async, however, and we might need to revisit it as a whole
later.
> Store job configurations in Timeline Service v2
> -----------------------------------------------
>
> Key: MAPREDUCE-6688
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6688
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: applicationmaster
> Affects Versions: YARN-2928
> Reporter: Junping Du
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: MAPREDUCE-6688-YARN-2928.01.patch,
> MAPREDUCE-6688-YARN-2928.02.patch, MAPREDUCE-6688-YARN-2928.03.patch,
> MAPREDUCE-6688-YARN-2928.v2.01.patch, YARN-3959-YARN-2928.01.patch
>
>
> We already have configuration field in HBase schema for application entity.
> We need to make sure AM write it out when it get launched.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
