[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486600#comment-15486600
 ] 

Kai Zheng commented on MAPREDUCE-6774:
--------------------------------------

Thanks [~Sammi] for the work!

It looks good overall. Suggestions:

{code}
boolean isStoragePolicyValid(String storagePolicy, FileSystem fs)
boolean isErasureCodePolicyValid(String erasureCodePolicyName, FileSystem fs, 
TestType testType) throws IOException
{code}
would be good to:
{code}
void checkStoragePolicy(String storagePolicy, FileSystem fs) throws Exception
void checkErasureCodePolicy(String erasureCodePolicyName, FileSystem fs, 
TestType testType) throws Exception
{code}


> Add support for HDFS erasure code policy to TestDFSIO
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-6774
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6774
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: SammiChen
>            Assignee: SammiChen
>         Attachments: MAPREDUCE-6774-v1.patch, MAPREDUCE-6774-v2.patch, 
> MAPREDUCE-6774-v3.patch
>
>
> HDFS erasure code policy allows user to store directory and file to 
> predefined erasure code policies. Currently only 3x replication is supported 
> in TestDFSIO implementation. This is going to add an new option to enable 
> tests of files with erasure code policy enabled. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to