[
https://issues.apache.org/jira/browse/MAPREDUCE-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15486876#comment-15486876
]
SammiChen commented on MAPREDUCE-6774:
--------------------------------------
Thanks Kai, for take time review the patch and give very good suggestion!
The name 'checkStoragePolicy' sounds better than 'isStoragePolicyValid'. So
does the name 'checkErasureCodePolicy'. I uploaded Patch v4 which contains the
improvement. One the other hand, I would suggest keep the return value
{{boolean}} of each check function. Because the {{main}} function depends on
the return value, not the exception, to handle the invalid parameter case.
> Add support for HDFS erasure code policy to TestDFSIO
> -----------------------------------------------------
>
> Key: MAPREDUCE-6774
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6774
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Reporter: SammiChen
> Assignee: SammiChen
> Attachments: MAPREDUCE-6774-v1.patch, MAPREDUCE-6774-v2.patch,
> MAPREDUCE-6774-v3.patch, MAPREDUCE-6774-v4.patch
>
>
> HDFS erasure code policy allows user to store directory and file to
> predefined erasure code policies. Currently only 3x replication is supported
> in TestDFSIO implementation. This is going to add an new option to enable
> tests of files with erasure code policy enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
