[
https://issues.apache.org/jira/browse/MAPREDUCE-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674746#comment-15674746
]
Naganarasimha G R commented on MAPREDUCE-6773:
----------------------------------------------
Hi Deva,
Sorry for the delay in reviewing.
# RMContainerRequestor ln no 607: One imp point which i wanted to mention was
that though only RMContainerReuseRequestor is making use of the
RMContainerReuseRequestor we have added it to the interface ContainerRequestor
due which we have a empty implementation here. So we need to make
RMContainerReuseRequestor implement {{EventHandler<ContainerRequestorEvent>}}
and move {{enum EventType}} out of ContainerRequestor to its own file or would
prefer to have it as part of RMContainerReuseRequestor itself.
# MRAppMaster ln no 966: Based on the previous comment i would prefer to do
this operation in RMContainerAllocator during initialization of
RMContainerReuseRequestor due to avoid the type cast or the instanceof check.
This it would imply that the dispatcher should be available in
RMContainerAllocator, hence either we need to set the dispatcher in the context
or initialize as part of constructor.
# RMContainerReuseRequestor ln no 133, we are checking for PRIORITY_MAP and
PRIORITY_REDUCE what about other priorities ? do we need to send
CONTAINER_REMOTE_CLEANUP,
# RMContainerReuseRequestor ln no 154, Similar to the earlier comment, here too
we need to send CONTAINER_REMOTE_CLEANUP.
Will further take look at the test cases...
> Implement RM Container Reuse Requestor to handle the reuse containers for
> resource requests
> -------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6773
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6773
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: applicationmaster, mrv2
> Affects Versions: MR-6749
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-6773-MR-6749.003.patch,
> MAPREDUCE-6773-MR-6749.004.patch, MAPREDUCE-6773-v0.patch,
> MAPREDUCE-6773-v1.patch, MAPREDUCE-6773-v2.patch
>
>
> Add RM Container Reuse Requestor which handles the reuse containers against
> the Job reource requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
