[
https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784241#comment-15784241
]
Junping Du commented on MAPREDUCE-6286:
---------------------------------------
Revert it from branch-2.8 given we revert MAPREDUCE-5875 per discussion in
MAPREDUCE-6288.
> A typo in HistoryViewer makes some code useless, which causes counter limits
> are not reset correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6286
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 2.6.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits
> are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
> final Path jobConfPath = new Path(jobFile.getParent(), jobDetails[0]
> + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
> final Configuration jobConf = new Configuration(conf);
> jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and
> reset the Limits based on the new configuration loaded from the Job
> configuration file. But with the typo, the Limits are reset with the old
> configuration.
> So this typo is apparent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
