[
https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105733#comment-16105733
]
Hudson commented on MAPREDUCE-6286:
-----------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12071 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/12071/])
Revert "MAPREDUCE-6286. A typo in HistoryViewer makes some code useless,
(junping_du: rev e15f92829558cc4a30b10f2fccfd17c2f8088003)
* (edit)
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/HistoryViewer.java
> A typo in HistoryViewer makes some code useless, which causes counter limits
> are not reset correctly.
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-6286
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: client
> Affects Versions: 2.6.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits
> are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
> final Path jobConfPath = new Path(jobFile.getParent(), jobDetails[0]
> + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
> final Configuration jobConf = new Configuration(conf);
> jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and
> reset the Limits based on the new configuration loaded from the Job
> configuration file. But with the typo, the Limits are reset with the old
> configuration.
> So this typo is apparent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
