[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786511#comment-15786511
 ] 

Naganarasimha G R commented on MAPREDUCE-6785:
----------------------------------------------

Hi [~devaraj.k],
OverAll patch seems to be fine except for few nits
# Patch name should be having branch name "MR-6749" 
# ln num 180: Local variable port will not be required as we have introduced 
newly shufflePort field in "Container".
# how about some test case?

Also one query, In cases where Speculative attempt is running, killing of a 
attempts should kill the container ?




> ContainerLauncherImpl support for reusing the containers
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-6785
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6785
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: applicationmaster, mrv2
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-6785-v0.patch, MAPREDUCE-6785-v1.patch, 
> MAPREDUCE-6785-v2.patch
>
>
> Add support to Container Launcher for reuse of the containers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to