[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895105#comment-15895105
 ] 

Devaraj K commented on MAPREDUCE-6785:
--------------------------------------

Thanks [~Naganarasimha] for the patch and apologize for the delay in review.

Patch looks ok to me except the Hadoop QA reported errors and some minor 
comments about the coding style.

1. TaskAttemptContainerAssignedEvent - Can we move move the setters and getters 
after the constructor?

2. RMContainerReuseRequestor -  Can we move the HostInfo inner class to the end 
of the class?

3. TaskAttemptImpl.java - Can we keep the same format as previous for these 
lines,
{code:xml}
-      taskAttempt.taskAttemptListener.registerPendingTask(
-          taskAttempt.remoteTask, taskAttempt.jvmID);
+      taskAttempt.taskAttemptListener
+          .registerPendingTask(taskAttempt.remoteTask, taskAttempt.jvmID);
{code}

> ContainerLauncherImpl support for reusing the containers
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-6785
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6785
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: applicationmaster, mrv2
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-6785-MR-6749.003.patch, 
> MAPREDUCE-6785-MR-6749.004.patch, MAPREDUCE-6785-v0.patch, 
> MAPREDUCE-6785-v1.patch, MAPREDUCE-6785-v2.patch
>
>
> Add support to Container Launcher for reuse of the containers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to