Steve Loughran commented on MAPREDUCE-4980:

good piece of maintenance on the tests here, they often get neglected "not a 
feature", but given how they get run by us developers more than any other piece 
of code, fast tests are wonderful.
# Is the test failure related? 
# w.r.t @Test(timeout), I much prefer having a timeout rule per class; if we do 
that rather than simply upping the value in the @Test clauses we set things up 
better for the future.
# Could {{MiniMRClientClusterBuilder}} implement {{Closeable.close()}}? As then 
we can use {{IOUtils.cleanupWithLogger()}} to close them in teardowns. Robust & 
logs problems. Also works in try-with-resources code like {{TestPipes}}
# If {{MiniMRClientClusterBuilder.namenode()}} was overriddent to take a URI or 
FileSystem, it'd be easier to setup
# {{TestMapperReducerCleanup}} no need to do an exists() check before delete(); 
its harmless if the path isn't there (and a serious regression if it does 
suddenly start complaining...)

other than that, LGTM. fine piece of work

> Parallel test execution of hadoop-mapreduce-client-core
> -------------------------------------------------------
>                 Key: MAPREDUCE-4980
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4980
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Andrey Klochkov
>         Attachments: MAPREDUCE-4980.010.patch, MAPREDUCE-4980.011.patch, 
> MAPREDUCE-4980.1.patch, MAPREDUCE-4980--n3.patch, MAPREDUCE-4980--n4.patch, 
> MAPREDUCE-4980--n5.patch, MAPREDUCE-4980--n6.patch, MAPREDUCE-4980--n7.patch, 
> MAPREDUCE-4980--n7.patch, MAPREDUCE-4980--n8.patch, MAPREDUCE-4980.patch
> The maven surefire plugin supports parallel testing feature. By using it, the 
> tests can be run more faster.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to