[
https://issues.apache.org/jira/browse/MAPREDUCE-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246377#comment-16246377
]
Robert Kanter commented on MAPREDUCE-6994:
------------------------------------------
Thanks for working on this [~miklos.szeg...@cloudera.com] and [~yufeigu] for
reviews so far.
Looks good overall. Here's some more comments:
# The new pom is missing the {{<version>}} and {{<name>}} elements for itself.
Take a look at a sibling pom like {{hadoop-mapreduce-client-shuffle}} for an
example.
# The new pom should declare all direct dependencies. I'm actually curious how
it's compiling with no dependencies defined...
# Why are we using a mix of {{LOG}} and {{System.out.print}}? We should use
{{LOG}}.
# In {{FrameworkUploader#buildPackage}}, instead of using our own {{buffer}}
with a {{while}} loop, we can just use {{IOUtils#copy}} from commons-io.
# In {{FrameworkUploader#buildPackage}}, we can use try-with-resources for
{{out}} and {{inputStream}}
# In {{FrameworkUploader}}, instead of manually formatting and printing out the
Help text, you can use the {{HelpFormatter}} from cli-commons along with the
{{Options}} you're already using. You can see an example of this in other CLI
tools, such as {{HadoopArchiveLogs}}.
# In {{TestFrameworkUploader}}, we should move {{RANDOM}} and {{TEST_DIR}} into
an {{@Before}} {{setUp}} method.
# Please file a followup JIRA for Windows support
> Uploader tool for Distributed Cache Deploy code changes
> -------------------------------------------------------
>
> Key: MAPREDUCE-6994
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6994
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Attachments: MAPREDUCE-6994.000.patch, MAPREDUCE-6994.001.patch,
> MAPREDUCE-6994.002.patch, MAPREDUCE-6994.003.patch, MAPREDUCE-6994.004.patch,
> MAPREDUCE-6994.005.patch
>
>
> The proposal is to create a tool that collects all available jars in the
> Hadoop classpath and adds them to a single tarball file. It then uploads the
> resulting archive to an HDFS directory. This saves the cluster administrator
> from having to set this up manually for Distributed Cache Deploy.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
