[ https://issues.apache.org/jira/browse/MAPREDUCE-7385?focusedWorklogId=778438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778438 ]
ASF GitHub Bot logged work on MAPREDUCE-7385: --------------------------------------------- Author: ASF GitHub Bot Created on: 05/Jun/22 09:41 Start Date: 05/Jun/22 09:41 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4403: URL: https://github.com/apache/hadoop/pull/4403#issuecomment-1146774015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 1m 18s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 100m 11s | | trunk passed | | +1 :green_heart: | compile | 0m 55s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 0m 51s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 0m 51s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 57s | | trunk passed | | +1 :green_heart: | javadoc | 0m 45s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 0m 34s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 1m 46s | | trunk passed | | +1 :green_heart: | shadedclient | 23m 58s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 38s | | the patch passed | | +1 :green_heart: | compile | 0m 43s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javac | 0m 43s | | hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new + 102 unchanged - 7 fixed = 102 total (was 109) | | +1 :green_heart: | compile | 0m 37s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 0m 37s | | hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new + 96 unchanged - 7 fixed = 96 total (was 103) | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 32s | | the patch passed | | +1 :green_heart: | mvnsite | 0m 43s | | the patch passed | | +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 1m 33s | | the patch passed | | +1 :green_heart: | shadedclient | 24m 13s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 29s | | hadoop-mapreduce-client-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 43s | | The patch does not generate ASF License warnings. | | | | 169m 23s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4403/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4403 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux e6837a197275 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 2ca28f008ceda2d9c4b648538d1fdb2816e9f044 | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4403/1/testReport/ | | Max. process+thread count | 1072 (vs. ulimit of 5500) | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4403/1/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. Issue Time Tracking ------------------- Worklog Id: (was: 778438) Time Spent: 20m (was: 10m) > impove JobEndNotifier#httpNotification With recommended methods > --------------------------------------------------------------- > > Key: MAPREDUCE-7385 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7385 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: fanshilun > Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > JobEndNotifier#httpNotification's DefaultHttpClient has been Deprecated, use > the recommended method instead > JobEndNotifier#httpNotification > {code:java} > private static int httpNotification(String uri, int timeout) > throws IOException, URISyntaxException { > DefaultHttpClient client = new DefaultHttpClient(); > client.getParams() > .setIntParameter(CoreConnectionPNames.SO_TIMEOUT, timeout) > .setLongParameter(ClientPNames.CONN_MANAGER_TIMEOUT, (long) timeout); > HttpGet httpGet = new HttpGet(new URI(uri)); > httpGet.setHeader("Accept", "*/*"); > return client.execute(httpGet).getStatusLine().getStatusCode(); > } {code} > * CoreConnectionPNames.SO_TIMEOUT > * Use RequestConfig.setSocketTimeout instead > {code:java} > Deprecated.Defines the socket timeout (SO_TIMEOUT) in milliseconds, which is > the timeout for waiting for data or, put differently, a maximum period > inactivity between two consecutive data packets). A timeout value of zero is > interpreted as an infinite timeout. {code} > > * ClientPNames.CONN_MANAGER_TIMEOUT > * Use RequestConfig.setConnectionRequestTimeout instead > {code:java} > Deprecated. Defines the timeout in milliseconds used when retrieving an > instance of ManagedClientConnection from the ClientConnectionManager. {code} > > > -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org