[ https://issues.apache.org/jira/browse/MAPREDUCE-7385?focusedWorklogId=782629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782629 ]
ASF GitHub Bot logged work on MAPREDUCE-7385: --------------------------------------------- Author: ASF GitHub Bot Created on: 18/Jun/22 13:24 Start Date: 18/Jun/22 13:24 Worklog Time Spent: 10m Work Description: slfan1989 commented on PR #4403: URL: https://github.com/apache/hadoop/pull/4403#issuecomment-1159464857 @prasad-acit Can you help me review the code?Thank you very much! Issue Time Tracking ------------------- Worklog Id: (was: 782629) Time Spent: 1h (was: 50m) > impove JobEndNotifier#httpNotification With recommended methods > --------------------------------------------------------------- > > Key: MAPREDUCE-7385 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7385 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: fanshilun > Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > JobEndNotifier#httpNotification's DefaultHttpClient has been Deprecated, use > the recommended method instead > JobEndNotifier#httpNotification > {code:java} > private static int httpNotification(String uri, int timeout) > throws IOException, URISyntaxException { > DefaultHttpClient client = new DefaultHttpClient(); > client.getParams() > .setIntParameter(CoreConnectionPNames.SO_TIMEOUT, timeout) > .setLongParameter(ClientPNames.CONN_MANAGER_TIMEOUT, (long) timeout); > HttpGet httpGet = new HttpGet(new URI(uri)); > httpGet.setHeader("Accept", "*/*"); > return client.execute(httpGet).getStatusLine().getStatusCode(); > } {code} > * CoreConnectionPNames.SO_TIMEOUT > * Use RequestConfig.setSocketTimeout instead > {code:java} > Deprecated.Defines the socket timeout (SO_TIMEOUT) in milliseconds, which is > the timeout for waiting for data or, put differently, a maximum period > inactivity between two consecutive data packets). A timeout value of zero is > interpreted as an infinite timeout. {code} > > * ClientPNames.CONN_MANAGER_TIMEOUT > * Use RequestConfig.setConnectionRequestTimeout instead > {code:java} > Deprecated. Defines the timeout in milliseconds used when retrieving an > instance of ManagedClientConnection from the ClientConnectionManager. {code} > > > -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org