[ https://issues.apache.org/jira/browse/MAPREDUCE-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648413#comment-17648413 ]
Ayush Saxena commented on MAPREDUCE-7428: ----------------------------------------- Further to add, this patch didn't fix things. This build has this fix: [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1075/#showFailuresLink] And it has 89 Failures, down from 150+ though. I tried one test locally to see if it was a build issue and it didn't pick up the latest changes or so. {noformat} [ERROR] TestHsWebServices.testHS:128->verifyHSInfo:281->verifyHsInfoGeneric:267 ? NoClassDefFound [ERROR] TestHsWebServices.testHSDefault:152->verifyHSInfo:281->verifyHsInfoGeneric:267 ? NoClassDefFound [ERROR] TestHsWebServices.testHSSlash:140->verifyHSInfo:281->verifyHsInfoGeneric:267 ? NoClassDefFound [ERROR] TestHsWebServices.testHSXML:163->verifyHSInfoXML:298->verifyHsInfoGeneric:267 ? NoClassDefFound {noformat} Now regarding the fix: 1. Tests should have been fixed not {*}eliminated{*}. Click on the next build button & see that the tests vanished [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1074/testReport/org.apache.hadoop.mapreduce.v2.app.webapp/] Check the latest build, which has this fix. [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1075/testReport/] It shows -437 tests {noformat} 24,240 tests (-437) {noformat} 2. What all places similar changes are done & what all tests are being skipped? 3. Why this is added twice, once at L127 & then at L142 {noformat} <dependency> <groupId>org.junit.platform</groupId> <artifactId>junit-platform-launcher</artifactId> <scope>test</scope> </dependency> {noformat} > Fix failures related to Junit 4 to Junit 5 upgrade in > org.apache.hadoop.mapreduce.v2.app.webapp > ----------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-7428 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7428 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Affects Versions: 3.4.0 > Reporter: Ashutosh Gupta > Assignee: Ashutosh Gupta > Priority: Critical > Labels: pull-request-available > Fix For: 3.4.0 > > > Few test are getting failed due to Junit 4 to Junit 5 upgrade in > org.apache.hadoop.mapreduce.v2.app.webapp > [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1071/testReport/] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org