[
https://issues.apache.org/jira/browse/MAPREDUCE-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649392#comment-17649392
]
Akira Ajisaka commented on MAPREDUCE-7428:
------------------------------------------
Thank you [~ayushtkn] [[email protected]] for taking care of the test failures.
Reading the test report
[https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1071/testReport/],
now I'm thinking MAPREDUCE-7428 is caused by YARN-6946, not by MAPREDUCE-7422.
The stacktrace is as below
{quote}java.lang.NoClassDefFoundError: org/junit/jupiter/api/Assertions at
org.apache.hadoop.yarn.webapp.WebServicesTestUtils.checkStringMatch(WebServicesTestUtils.java:124)
at
org.apache.hadoop.mapreduce.v2.hs.webapp.TestHsWebServices.verifyHsInfoGeneric(TestHsWebServices.java:267)
{quote}
and it's caused by the junit upgrade in WebServicesTestUtils.java in
hadoop-yarn-common module. The class is used not only from YARN but also from
MapReduce modules, so upgrading the class caused the failures. Sorry I didn't
notice it until breaking a lot of tests.
{quote}Something like this fixed for me, enabled the disabled the test and
fixed the failing test.
{quote}
Yeah, junit-vintage-engine is useful when both junit 4 and 5 test classes exist.
There are several ways to fix it:
# Revert YARN-6946
# Remove JUnit APIs from WebServicesTestUtils. I don't think the helper
methods such as checkStringMatch, checkStringContains, and checkStringEqual are
useful. We can simply use AssertJ APIs instead.
# Apply Ayush's patch in the above.
I think we should go with the option 1 for quick fix.
[~groot] we need to be more careful, probably we need to run full build and
test when upgrading junit in a module.
> Fix failures related to Junit 4 to Junit 5 upgrade in
> org.apache.hadoop.mapreduce.v2.app.webapp
> -----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7428
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7428
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 3.4.0
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Few test are getting failed due to Junit 4 to Junit 5 upgrade in
> org.apache.hadoop.mapreduce.v2.app.webapp
> [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1071/testReport/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
