[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648893#comment-17648893
 ] 

ASF GitHub Bot commented on MAPREDUCE-7429:
-------------------------------------------

slfan1989 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1051386018


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java:
##########
@@ -428,6 +429,12 @@ public static String getAggregatedLogURL(String 
serverHttpAddress,
         user == null || user.isEmpty()) {
       return null;
     }
+    String [] ipAdds = serverHttpAddress.split("//");
+    if (StringUtils.countMatches(ipAdds[1], ":") > 2) {

Review Comment:
   Should we check the length of this array after split, and NPE may occur if 
we use it directly?





> Application log link is not accessible via TimelineServer Web UI in IPV6 
> scenario
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7429
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7429
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Daniel Ma
>            Priority: Major
>              Labels: pull-request-available
>
> Application log link is not accessible via TimelineServer Web UI in IPV6 
> scenario owning to no ipv6 normalization.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to