[
https://issues.apache.org/jira/browse/MAPREDUCE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649411#comment-17649411
]
ASF GitHub Bot commented on MAPREDUCE-7429:
-------------------------------------------
goiri commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1052442938
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##########
@@ -247,6 +247,24 @@ public static InetSocketAddress createSocketAddr(String
target,
return createSocketAddrForHost(host, port);
}
+ public static String normalizeV6Address(String target) {
+ if (!target.startsWith("[")) {
+ if (target.contains("%")) {
+ int i = target.lastIndexOf('%');
+ target = target.trim();
+ String port = target.substring(target.lastIndexOf(":") + 1);
+ String addr = target.substring(0, i);
+ target = "[" + addr + "]" + ":" + port;
Review Comment:
Make the input target final in the declaration and return a new variable.
```
public static String normalizeV6Address(final String target) {
```
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##########
@@ -247,6 +247,24 @@ public static InetSocketAddress createSocketAddr(String
target,
return createSocketAddrForHost(host, port);
}
+ public static String normalizeV6Address(String target) {
Review Comment:
Add unit tests for this.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineConnector.java:
##########
@@ -197,6 +199,12 @@ private static void setTimeouts(URLConnection connection,
int socketTimeout) {
public static URI constructResURI(Configuration conf, String address,
String uri) {
+ if (StringUtils.countMatches(address, ":") > 2) {
Review Comment:
This probable be in NetUtils and be a proper isIPV6Address() or something.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##########
@@ -247,6 +247,24 @@ public static InetSocketAddress createSocketAddr(String
target,
return createSocketAddrForHost(host, port);
}
+ public static String normalizeV6Address(String target) {
+ if (!target.startsWith("[")) {
Review Comment:
I'm pretty sure regex would help here.
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7429
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7429
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Daniel Ma
> Priority: Major
> Labels: pull-request-available
>
> Application log link is not accessible via TimelineServer Web UI in IPV6
> scenario owning to no ipv6 normalization.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
