[ https://issues.apache.org/jira/browse/MAPREDUCE-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649662#comment-17649662 ]
ASF GitHub Bot commented on MAPREDUCE-7429: ------------------------------------------- Daniel-009497 commented on code in PR #5236: URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053132520 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java: ########## @@ -229,6 +230,23 @@ public static InetSocketAddress createSocketAddr(String target, } target = target.trim(); boolean hasScheme = target.contains("://"); + if (StringUtils.countMatches(target, ":") > 2) { + // if scheme exists in the target, for example: + // https://ffff:ffff:ffff:ffff::1:XXXX will be formed like + // https://[ffff:ffff:ffff:ffff::1]:XXXX Review Comment: Thanks for review. modified as you mentioned. Pls help to merge once the pipeline is down. And pls help to review the other PR I raised if you got time. Thanks a lot. > Application log link is not accessible via TimelineServer Web UI in IPV6 > scenario > --------------------------------------------------------------------------------- > > Key: MAPREDUCE-7429 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7429 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Daniel Ma > Assignee: Daniel Ma > Priority: Major > Labels: pull-request-available > > Application log link is not accessible via TimelineServer Web UI in IPV6 > scenario owning to no ipv6 normalization. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org