[
https://issues.apache.org/jira/browse/MAPREDUCE-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649722#comment-17649722
]
ASF GitHub Bot commented on MAPREDUCE-7428:
-------------------------------------------
slfan1989 commented on code in PR #5243:
URL: https://github.com/apache/hadoop/pull/5243#discussion_r1053258375
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/TestContainerLogsUtils.java:
##########
@@ -75,13 +73,12 @@ public static void
createContainerLogFileInRemoteFS(Configuration conf,
if (fs.exists(rootLogDirPath)) {
fs.delete(rootLogDirPath, true);
}
- assertTrue(fs.mkdirs(rootLogDirPath));
+ fs.mkdirs(rootLogDirPath);
Path appLogsDir = new Path(rootLogDirPath, appId.toString());
if (fs.exists(appLogsDir)) {
fs.delete(appLogsDir, true);
}
- assertTrue(fs.mkdirs(appLogsDir));
-
+ fs.mkdirs(appLogsDir);
Review Comment:
Thanks a lot for asking, I think we should keep this `assertTrue`.
We are currently experiencing some difficulties.
`TestContainerLogsUtils.java` uses assertTrue of `org.junit.jupiter`,
`hadoop-mapreduce-client-hs` and `hadoop-mapreduce-client-app` use
`TestContainerLogsUtils.java`, `hadoop-mapreduce-client-hs` and
`hadoop-mapreduce-client-app` These two modules have not upgraded the junit
test, so when running the test, the classes cannot be found.
`hadoop-mapreduce-client-hs` and `hadoop-mapreduce-client-app` may take some
time to upgrade junit test.
aajisaka's idea can quickly fix this problem without affecting the
compilation of other modules.
I will continue to follow up the `mapreduce` junit upgrade. If the mapreduce
module junit upgrade is completed, I will change this back.
> Fix failures related to Junit 4 to Junit 5 upgrade in
> org.apache.hadoop.mapreduce.v2.app.webapp
> -----------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7428
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7428
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 3.4.0
> Reporter: Ashutosh Gupta
> Assignee: Ashutosh Gupta
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Few test are getting failed due to Junit 4 to Junit 5 upgrade in
> org.apache.hadoop.mapreduce.v2.app.webappÂ
> [https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1071/testReport/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
