[
https://issues.apache.org/jira/browse/MAPREDUCE-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748191#comment-17748191
]
ASF GitHub Bot commented on MAPREDUCE-7446:
-------------------------------------------
brumi1024 commented on PR #5895:
URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1653771314
> `// Read key and value lengths currentKeyLength =
WritableUtils.readVInt(dIn); currentValueLength = WritableUtils.readVInt(dIn);
bytesRead += WritableUtils.getVIntSize(currentKeyLength) +
WritableUtils.getVIntSize(currentValueLength);`
>
> bytesRead can overflow as well.
There are a lot of long = int + int type operations, which will overflow, as
there is no widening happening. Since we use these as readLength this can
result in strange bugs, so probably those should be rewritten.
> NegativeArraySizeException when running MR jobs with large data size
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-7446
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7446
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Peter Szucs
> Assignee: Peter Szucs
> Priority: Major
> Labels: pull-request-available
>
> We are using bit shifting to double the byte array in IFile's
> [nextRawValue|https://github.infra.cloudera.com/CDH/hadoop/blob/bef14a39c7616e3b9f437a6fb24fc7a55a676b57/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/IFile.java#L437]
> method to store the byte values in it. With large dataset it can easily
> happen that we shift the leftmost bit when we are calculating the size of the
> array, which can lead to a negative number as the array size, causing the
> NegativeArraySizeException.
> It would be safer to expand the backing array with a 1.5x factor, and have a
> check not to extend Integer's max value during that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
