[
https://issues.apache.org/jira/browse/MAPREDUCE-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752777#comment-17752777
]
ASF GitHub Bot commented on MAPREDUCE-7449:
-------------------------------------------
brumi1024 commented on code in PR #5935:
URL: https://github.com/apache/hadoop/pull/5935#discussion_r1290018339
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java:
##########
@@ -163,19 +164,19 @@ public void testCommandLineWithLog4JConifg() throws
Exception {
Assert.assertEquals(
"[" + MRApps.crossPlatformify("JAVA_HOME") + "/bin/java" +
- " -Djava.net.preferIPv4Stack=true" +
- " -Dhadoop.metrics.log.level=WARN " +
- " -Xmx820m -Djava.io.tmpdir=" + MRApps.crossPlatformify("PWD") + "/tmp"
+
- " -Dlog4j.configuration=" + testLogPropertieFile +
- " -Dyarn.app.container.log.dir=<LOG_DIR>" +
- " -Dyarn.app.container.log.filesize=0" +
- " -Dhadoop.root.logger=INFO,CLA -Dhadoop.root.logfile=syslog" +
- " org.apache.hadoop.mapred.YarnChild 127.0.0.1" +
- " 54321" +
- " attempt_0_0000_m_000000_0" +
- " 0" +
- " 1><LOG_DIR>/stdout" +
- " 2><LOG_DIR>/stderr ]", app.launchCmdList.get(0));
+ " -Djava.net.preferIPv4Stack=true" +
Review Comment:
Fixed, thanks.
> Add add-opens flag to container launch commands on JDK17 nodes
> --------------------------------------------------------------
>
> Key: MAPREDUCE-7449
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7449
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: mr-am, mrv2
> Affects Versions: 3.4.0
> Reporter: Benjamin Teke
> Assignee: Benjamin Teke
> Priority: Major
> Labels: pull-request-available
>
> To allow containers to launch on JDK17 nodes the add-opens flag should be
> added to the container launch commands if the node has JDK17+, and it
> shouldn't on previous JDKs. This behaviour should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
