[ https://issues.apache.org/jira/browse/MAPREDUCE-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777451#comment-17777451 ]
ASF GitHub Bot commented on MAPREDUCE-7449: ------------------------------------------- hadoop-yetus commented on PR #6204: URL: https://github.com/apache/hadoop/pull/6204#issuecomment-1771632684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 5m 57s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 0s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 1s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. | |||| _ branch-3.3 Compile Tests _ | | +0 :ok: | mvndep | 15m 42s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 35m 6s | | branch-3.3 passed | | +1 :green_heart: | compile | 18m 25s | | branch-3.3 passed | | +1 :green_heart: | checkstyle | 2m 45s | | branch-3.3 passed | | +1 :green_heart: | mvnsite | 5m 26s | | branch-3.3 passed | | +1 :green_heart: | javadoc | 4m 19s | | branch-3.3 passed | | +1 :green_heart: | spotbugs | 8m 29s | | branch-3.3 passed | | +1 :green_heart: | shadedclient | 35m 15s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 39s | | the patch passed | | +1 :green_heart: | compile | 17m 44s | | the patch passed | | +1 :green_heart: | javac | 17m 44s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 2m 45s | [/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6204/1/artifact/out/results-checkstyle-root.txt) | root: The patch generated 4 new + 731 unchanged - 1 fixed = 735 total (was 732) | | +1 :green_heart: | mvnsite | 5m 24s | | the patch passed | | +1 :green_heart: | javadoc | 4m 14s | | the patch passed | | +1 :green_heart: | spotbugs | 9m 44s | | the patch passed | | +1 :green_heart: | shadedclient | 35m 11s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 14s | | hadoop-yarn-api in the patch passed. | | +1 :green_heart: | unit | 23m 2s | | hadoop-yarn-server-nodemanager in the patch passed. | | +1 :green_heart: | unit | 19m 52s | | hadoop-yarn-applications-distributedshell in the patch passed. | | +1 :green_heart: | unit | 7m 43s | | hadoop-mapreduce-client-core in the patch passed. | | +1 :green_heart: | unit | 8m 56s | | hadoop-mapreduce-client-app in the patch passed. | | +1 :green_heart: | unit | 127m 27s | | hadoop-mapreduce-client-jobclient in the patch passed. | | +1 :green_heart: | asflicense | 1m 2s | | The patch does not generate ASF License warnings. | | | | 405m 46s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6204/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6204 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint | | uname | Linux d89393957425 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / 688a1154ca0995a2d181381ee8e86c8ce6ad2faf | | Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6204/1/testReport/ | | Max. process+thread count | 1571 (vs. ulimit of 5500) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6204/1/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Add add-opens flag to container launch commands on JDK17 nodes > -------------------------------------------------------------- > > Key: MAPREDUCE-7449 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7449 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Components: mr-am, mrv2 > Affects Versions: 3.4.0, 3.3.7 > Reporter: Benjamin Teke > Assignee: Benjamin Teke > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > > To allow containers to launch on JDK17 nodes the add-opens flag should be > added to the container launch commands if the node has JDK17+, and it > shouldn't on previous JDKs. This behaviour should be configurable. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org