Thanks so much for these fixes Even, I've removed the workarounds.
-jeff
On 2022-05-23 4:04 p.m., Even Rouault wrote:
I could actually reproduce them with: cmake -DCMAKE_C_FLAGS="-O2 -Wall
-Werror -Wextra" -DCMAKE_CXX_FLAGS="-O2 -Wall -Werror -Wextra"
Some of them are actually serious. Fixes queued in
https://github.com/MapServer/MapServer/pull/6531
Once it is merged, you can rebase your branch on top of it and drop your
workarounds:
git fetch origin main
git rebase origin/main
git push -f your_remote your_branch
(assuming 'origin' is the name of the remote to the upstream repositoy)
Le 23/05/2022 à 20:18, Jeff McKenna a écrit :
Thanks Even, I saved the 2 errors locally (next time I'll save the log
url instead) : https://pastebin.com/4GAiVhLx
(yes very difficult to reproduce locally)
-jeff
On 2022-05-23 2:15 p.m., Even Rouault wrote:
Jeff,
is there a build log somewhere with the warnings in mapowscommon /
mapjoin ? I can't reproduce that locally with my native Focal
environement. Perhaps a different set of compilation options or
different compiler version.
Even
Le 23/05/2022 à 18:16, Jeff McKenna a écrit :
Hi all,
I thought I'd share some interesting updates from my side, for the
8.0 release:
- Travis and GitHub build actions have been updated to run on Ubuntu
Focal (20.04)
- the builds compile PHPNG MapScript for 7.4.6, 8.0.19, 8.1.6 /
Python MapScript 3.7.7, 3.8.3, 3.9.0 without any issues
- msautotests: I've made it down to about 20 broken tests (from
about 200, yikes)
- of note, is that the existing flag "-Werror" while compiling
MapServer (which means break on all warnings, treat warnings as
errors) does cause issues in several files (mappwscommon.c,
majoin.c), so the nasty workaround is to set -Wno-stringop-overflow,
-Wno-format-overflow in the build script, which is not good, meaning
that these warnings should be fixed and -Werror reset.
You can follow along or made changes at
https://github.com/MapServer/MapServer/pull/6430
I think the upgrade to a more recent Ubuntu for all of our tests was
critical for the 8.0 release (which is why I put so much darn effort
in that).
Hope this looks good to everyone. Exciting,
-jeff
_______________________________________________
MapServer-dev mailing list
[email protected]
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
