----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117390/ -----------------------------------------------------------
(Updated April 9, 2014, 10:05 p.m.) Review request for Marble. Repository: marble Description ------- This patch adds more installed headers files. It addresses the issues described here : http://forum.kde.org/viewtopic.php?f=217&t=120442 I have tried to remove some cloudsync/*.h includes to avoid exposing them. I did this by forward declaring cloudsync classes in a few places. Unfortunately, in one critical file, namely QtMarbleConfigDialog, it was not possible to forward declare a cloudsync class. And this because, a method was added that references a cloudsync enum and enums cannot be forward declared (at least with with current C++ version). Diffs ----- src/apps/marble-qt/CMakeLists.txt 432d056 src/apps/marble-qt/QtMainWindow.cpp 221cbc7 src/apps/marble-ui/CMakeLists.txt c56c51a src/apps/marble-ui/ControlView.cpp cf69c5e src/lib/marble/CMakeLists.txt bb6f312 src/lib/marble/QtMarbleConfigDialog.h d710a96 src/lib/marble/cloudsync/CloudSyncManager.h cafdad3 src/lib/marble/cloudsync/CloudSyncManager.cpp 463c38e src/lib/marble/cloudsync/RouteSyncManager.h 46e9526 src/lib/marble/cloudsync/RouteSyncManager.cpp 4f0631b Diff: https://git.reviewboard.kde.org/r/117390/diff/ Testing ------- Thanks, Philippe Renon
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
