----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117390/#review55415 -----------------------------------------------------------
This review has been submitted with commit 30ea53f671693da67d83a9e17299f2b6cef6f502 by Dennis Nienhüser on behalf of Philippe Renon to branch master. - Commit Hook On April 9, 2014, 11:53 p.m., Philippe Renon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117390/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 11:53 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch adds more installed headers files. > It addresses the issues described here : > http://forum.kde.org/viewtopic.php?f=217&t=120442 > > I have tried to remove some cloudsync/*.h includes to avoid exposing them. > I did this by forward declaring cloudsync classes in a few places. > > Unfortunately, in one critical file, namely QtMarbleConfigDialog, it was not > possible to forward declare a cloudsync class. > And this because, a method was added that references a cloudsync enum and > enums cannot be forward declared (at least with with current C++ version). > > > Diffs > ----- > > src/apps/marble-qt/QtMainWindow.cpp 221cbc7 > src/apps/marble-ui/ControlView.cpp cf69c5e > src/lib/marble/CMakeLists.txt bb6f312 > src/lib/marble/QtMarbleConfigDialog.h 1354576 > src/lib/marble/QtMarbleConfigDialog.cpp 482c7a9 > src/lib/marble/cloudsync/CloudSyncManager.h 3a0351a > src/lib/marble/cloudsync/CloudSyncManager.cpp c644bb6 > src/lib/marble/cloudsync/RouteSyncManager.h 46e9526 > src/lib/marble/cloudsync/RouteSyncManager.cpp 4f0631b > > Diff: https://git.reviewboard.kde.org/r/117390/diff/ > > > Testing > ------- > > > Thanks, > > Philippe Renon > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
