----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118040/#review57527 -----------------------------------------------------------
Ship it! Good catch, please push! - Dennis Nienhüser On May 7, 2014, 7:53 p.m., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118040/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 7:53 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > The current implementation of GeoDataFlyTo::operator== compares the m_view's > which are GeoDataAbstractView pointers and it was causing some tests to fail > after implementing TestGeoDataWriter::saveAndCompareEquality method. It was > also caused by the fact that the unit tests for this operator were pretty > poorely written. > > The implementation I propose checks the nodeType of each m_view (this' and > other's) and casts it to GeoDataCamera or GeoDataLookAt according to the > check. > > > Diffs > ----- > > src/lib/marble/geodata/data/GeoDataFlyTo.cpp 2ddcad8 > > Diff: https://git.reviewboard.kde.org/r/118040/diff/ > > > Testing > ------- > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
