----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118040/ -----------------------------------------------------------
(Updated May 8, 2014, 12:47 a.m.) Status ------ This change has been marked as submitted. Review request for Marble. Repository: marble Description ------- The current implementation of GeoDataFlyTo::operator== compares the m_view's which are GeoDataAbstractView pointers and it was causing some tests to fail after implementing TestGeoDataWriter::saveAndCompareEquality method. It was also caused by the fact that the unit tests for this operator were pretty poorely written. The implementation I propose checks the nodeType of each m_view (this' and other's) and casts it to GeoDataCamera or GeoDataLookAt according to the check. Diffs ----- src/lib/marble/geodata/data/GeoDataFlyTo.cpp 2ddcad8 Diff: https://git.reviewboard.kde.org/r/118040/diff/ Testing ------- Thanks, Cruceru Calin-Cristian
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
