----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118190/#review58204 -----------------------------------------------------------
Ship it! Please push with the corrections below src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118190/#comment40465> tr( "Play" ); src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118190/#comment40464> tr( "Pause" ); src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118190/#comment40466> Let's shorten it to tr( "Current map center" ). Center instead of centre cause american english is favored. I wonder if the save action is too subtle though. Ideally the edit button (icon only atm) would show text in edit mode and read "Save". src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118190/#comment40462> Let's spare the else if... part below: if( first.contains( mouseEvent->pos() ) || second.contains( mouseEvent->pos() ) ) { GeoDataTourControl::PlayMode const playMode = first.contains( mouseEvent->pos() ) ? GeoDataTourControl::Play : GeoDataTourControl::Pause; ... tourControl->setPlayMode( playMode ); ... src/lib/marble/TourWidget.cpp <https://git.reviewboard.kde.org/r/118190/#comment40463> m_editingIndices.removeOne( index ); has the same effect and is twice as fast. - Dennis Nienhüser On May 19, 2014, 5:56 p.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118190/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 5:56 p.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch implements the following unctionalities: > - when an user clicks on the Edit button of a FlyTo element, then it will > prompt the user to make the map's focus point the new point which he/she > wants to make the new coordinates of the element. Clicking on Edit again will > update and save this new coordinate. > - when an user clicks on the Edit button of a TourControl element, it will > show two radio buttons, and the user has select one of them. When he clicks > on any one of "Play" or "Pause", the radio buttons disappear and the changes > get reflected on the playlist immediately. The "Edit" button in this case is > a toggle button between Change/Not-Change > > > Diffs > ----- > > src/lib/marble/TourWidget.h c38d620 > src/lib/marble/TourWidget.cpp aff7e99 > > Diff: https://git.reviewboard.kde.org/r/118190/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
