> On May 21, 2014, 1:50 a.m., Dennis Nienhüser wrote: > > src/lib/marble/TourWidget.cpp, line 227 > > <https://git.reviewboard.kde.org/r/118190/diff/2/?file=273490#file273490line227> > > > > Let's shorten it to tr( "Current map center" ). Center instead of > > centre cause american english is favored. > > > > I wonder if the save action is too subtle though. Ideally the edit > > button (icon only atm) would show text in edit mode and read "Save". > >
I will make sure to add the functionality of showing the text "Save" in the Edit button in edit mode in my next patch - Sanjiban ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118190/#review58204 ----------------------------------------------------------- On May 21, 2014, 2:49 a.m., Sanjiban Bairagya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118190/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 2:49 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > This patch implements the following unctionalities: > - when an user clicks on the Edit button of a FlyTo element, then it will > prompt the user to make the map's focus point the new point which he/she > wants to make the new coordinates of the element. Clicking on Edit again will > update and save this new coordinate. > - when an user clicks on the Edit button of a TourControl element, it will > show two radio buttons, and the user has select one of them. When he clicks > on any one of "Play" or "Pause", the radio buttons disappear and the changes > get reflected on the playlist immediately. The "Edit" button in this case is > a toggle button between Change/Not-Change > > > Diffs > ----- > > src/lib/marble/TourWidget.h c38d620 > src/lib/marble/TourWidget.cpp aff7e99 > > Diff: https://git.reviewboard.kde.org/r/118190/diff/ > > > Testing > ------- > > > Thanks, > > Sanjiban Bairagya > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
