Hi, okay, finally found some time to learn how to use post-review, nice tool :)
The average /= dividing by zero can't happen as far as I can see, but I've added another check to the while-loop making sure averageStart is never greater than index. Tried around with the scrollbar already. Even though I've done a lot with Qt my QML-experience is zero up to now, so I guess I will need to learn a bit more about it first ;) Greetings, Oliver Am Donnerstag 15 Mai 2014, 10:00:40 schrieb Torsten Rahn: > Hi Oliver, > > Looks nice. Could you add it to https://git.reviewboard.kde.org/dashboard/ ? > :-) > > Just a thing I noticed without a deep understanding of the algorithm: Could > there be a danger of the "average /= .... " line ever dividing by zero? > > Regarding your scrollbar requests: feel free to provide patches for > improving Marble :-) > > Best Regards, > Torsten > > > -----Original-Nachricht----- > Betreff: [Marble-devel] Improvements for climb/descend calculation routines > Datum: Thu, 15 May 2014 09:42:48 +0200 > Von: Oliver Haag <[email protected]> > An: [email protected] > > Hi, > > I'm currently creating some cycling routes with Marble (Really awesome > overall for this task! :)). > One thing that I've found out is that the climb and descend height of the > elevation profile aren't very accurate (Usually to large). I've modified the > averaging algorithm to average over 200 meters (Probably another value > would be even better, not sure) instead of 5 points (Those can be very > close together or really far away from each other). > This approach gives pretty good values for me so far. I've attached the > patch for it to this mail, averageDistance specifies the distance the > algorithms averages over in meters. > > Greetings, > > Oliver > > > P.S.: If you specify many waypoints for your route the dock for the route > gets really large vertically - would be nice to have a scrollbar there :) _______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
