----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118766/#review60344 -----------------------------------------------------------
src/plugins/render/annotate/AnnotatePlugin.cpp <https://git.reviewboard.kde.org/r/118766/#comment42061> Could we possibly leak memory here? Is there the possibility that we created multiple dialogs without deleting them? You might also consider this read: http://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0 - Torsten Rahn On June 16, 2014, 4:05 p.m., Cruceru Calin-Cristian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118766/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 4:05 p.m.) > > > Review request for Marble, Dennis Nienhüser and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > I added a pretty simple customization option for drawn polygons which > includes the following: > - polygon area/lines color and opacity modifying; > - lines width modifying; > - polygon area filling can be set to "Not Filled". > > Waiting for suggestions on what else would be nice to have as well as remarks > about this implementation. > > PS: It is what I have been working on for the last two days, so there is not > too much code, but I think it is better than submitting large patches as I > did last time. > > > Diffs > ----- > > src/plugins/render/annotate/AnnotatePlugin.h a401714 > src/plugins/render/annotate/AnnotatePlugin.cpp 2aca70e > src/plugins/render/annotate/AreaAnnotation.cpp 1a4452b > src/plugins/render/annotate/CMakeLists.txt 6caa034 > src/plugins/render/annotate/EditGroundOverlayDialog.ui 9873e8c > src/plugins/render/annotate/EditPolygonDialog.h PRE-CREATION > src/plugins/render/annotate/EditPolygonDialog.cpp PRE-CREATION > src/plugins/render/annotate/EditPolygonDialog.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118766/diff/ > > > Testing > ------- > > It works very nice. > > > Thanks, > > Cruceru Calin-Cristian > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
