----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118766/ -----------------------------------------------------------
(Updated June 18, 2014, 2:26 p.m.) Review request for Marble, Dennis Nienhüser and Torsten Rahn. Changes ------- Few changes to avoid memory leaks: - for EditPolygonDialog, since it is used as a modeless dialog (dialog->show()) the discussion from the link added by Torsten does not apply in this case. Indeed, the dialog was not deleted, so I looked up a way to delete it taking into consideration that it is a modeless dialog and I got to this: http://stackoverflow.com/questions/7069282/qt-modeless-dialog-destruction. So this is what I did. It looks ok to me. - since Tackat pointed out, there were problems with EditGroundOverlay as well. Even though it was not the purpose of this post, I think it is better to solve the problems as soon as we come across them. So, since this is a modal dialog, I used (according to the post Torsten linked to) a QPointer and deleted it after dialog->exec(). Repository: marble Description ------- I added a pretty simple customization option for drawn polygons which includes the following: - polygon area/lines color and opacity modifying; - lines width modifying; - polygon area filling can be set to "Not Filled". Waiting for suggestions on what else would be nice to have as well as remarks about this implementation. PS: It is what I have been working on for the last two days, so there is not too much code, but I think it is better than submitting large patches as I did last time. Diffs (updated) ----- src/plugins/render/annotate/AnnotatePlugin.h a401714 src/plugins/render/annotate/AnnotatePlugin.cpp 2aca70e src/plugins/render/annotate/AreaAnnotation.cpp 1a4452b src/plugins/render/annotate/CMakeLists.txt 6caa034 src/plugins/render/annotate/EditGroundOverlayDialog.ui 9873e8c src/plugins/render/annotate/EditPolygonDialog.h PRE-CREATION src/plugins/render/annotate/EditPolygonDialog.cpp PRE-CREATION src/plugins/render/annotate/EditPolygonDialog.ui PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118766/diff/ Testing ------- It works very nice. Thanks, Cruceru Calin-Cristian
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
