----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122731/#review76768 -----------------------------------------------------------
Makes sense generally. I do not have a system to test with at the moment, but the problems with plugin loading sound like a must-fix before shipping. Got some details on it? Do some plugins load, or none? Is it related to the qt version? - Dennis Nienhüser On Feb. 26, 2015, 6:50 nachm., Rex Dieter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122731/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 6:50 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Support qt4/qt5 parallel-installabie libmarblewidget. Current mplementation > preserves compatibility with qt4 builds, and qt5 builds changes base library > soname to be libmarblewidget-qt5 instead. > > > Diffs > ----- > > CMakeLists.txt ace9a51 > FindMarble.cmake 99f017a > FindMarble.cmake.in PRE-CREATION > MarbleMacros.cmake b86481f > src/apps/marble-kde/CMakeLists.txt 384f867 > src/apps/marble-mobile/CMakeLists.txt b86cac1 > src/apps/marble-qt/CMakeLists.txt 75b465e > src/apps/marble-touch/CMakeLists.txt 1d37cd4 > src/apps/marble-ui/CMakeLists.txt 74f1849 > src/bindings/python/CMakeLists.txt 57683cb > src/lib/marble/CMakeLists.txt 6c65015 > src/plasmarunner/CMakeLists.txt b52cc35 > src/plasmoid/CMakeLists.txt 03e251c > src/plugins/designer/latloneditwidget/CMakeLists.txt eb5d543 > src/plugins/runner/gpx/CMakeLists.txt aed6f83 > src/thumbnailer/CMakeLists.txt 175b5fc > > Diff: https://git.reviewboard.kde.org/r/122731/diff/ > > > Testing > ------- > > Marble and subsurface (a qt5 app that uses libmarblewidget) builds and > runs... mostly (there seems to be some problem with loading marble plugins > though) > > > Thanks, > > Rex Dieter > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
