Being on qt5 already I very much favor this option : Qt4: libmarblewidget-qt4-
Qt5: libmarblewidget
;)
Philippe.
Le Dimanche 1 mars 2015 20h01, Dennis Nienhüser <[email protected]> a
écrit :
| This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122731/ |
On February 28th, 2015, 4:06 p.m. UTC, Dennis Nienhüser wrote:
Makes sense generally. I do not have a system to test with at the moment, but
the problems with plugin loading sound like a must-fix before shipping. Got
some details on it? Do some plugins load, or none? Is it related to the qt
version?
On February 28th, 2015, 4:55 p.m. UTC, Rex Dieter wrote:
Looks like I'm getting the same crashes without this patch, so probably
unrelated. I'll file a bug (separately).
On March 1st, 2015, 6:25 a.m. UTC, Rex Dieter wrote:
bug filed, https://bugs.kde.org/show_bug.cgi?id=344692
With this patch we get- Qt4: libmarblewidget- Qt5: libmarblewidget-qt5Other
options would be- Qt4: libmarblewidget-qt4- Qt5: libmarblewidgetand also- Qt4:
libmarblewidget-qt4- Qt5: libmarblewidget-qt5and last but not least using
different folders for each installation.I'm mereley thinking aloud to avoid
that we forget a viable option. The current patch might confuse some people /
build scripts when changing from qt4 to qt5 and the (possibly hardcoded)
libmarblewidget does not exist anymore. Using
libmarblewidget-qt4/libmarblewidget would stress that qt5 is the new default
which I'd like to push; using libmarblewidget-qt4/libmarblewidget-qt5 seems
more consistent.Opinions, anyone?
- Dennis
On February 26th, 2015, 6:50 p.m. UTC, Rex Dieter wrote:
| Review request for Marble.By Rex Dieter.Updated Feb. 26, 2015, 6:50 p.m.
Repository: marble
Description
| Support qt4/qt5 parallel-installabie libmarblewidget. Current mplementation
preserves compatibility with qt4 builds, and qt5 builds changes base library
soname to be libmarblewidget-qt5 instead. |
Testing
| Marble and subsurface (a qt5 app that uses libmarblewidget) builds and
runs... mostly (there seems to be some problem with loading marble plugins
though) |
Diffs
- CMakeLists.txt (ace9a51)
- FindMarble.cmake (99f017a)
- FindMarble.cmake.in (PRE-CREATION)
- MarbleMacros.cmake (b86481f)
- src/apps/marble-kde/CMakeLists.txt (384f867)
- src/apps/marble-mobile/CMakeLists.txt (b86cac1)
- src/apps/marble-qt/CMakeLists.txt (75b465e)
- src/apps/marble-touch/CMakeLists.txt (1d37cd4)
- src/apps/marble-ui/CMakeLists.txt (74f1849)
- src/bindings/python/CMakeLists.txt (57683cb)
- src/lib/marble/CMakeLists.txt (6c65015)
- src/plasmarunner/CMakeLists.txt (b52cc35)
- src/plasmoid/CMakeLists.txt (03e251c)
- src/plugins/designer/latloneditwidget/CMakeLists.txt (eb5d543)
- src/plugins/runner/gpx/CMakeLists.txt (aed6f83)
- src/thumbnailer/CMakeLists.txt (175b5fc)
View Diff |
_______________________________________________
Marble-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/marble-devel
_______________________________________________
Marble-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/marble-devel
