----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124096/#review81491 -----------------------------------------------------------
src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp (line 50) <https://git.reviewboard.kde.org/r/124096/#comment55854> memory leak. why not use a const reference as method parameter in writeNode to avoid problems like this? src/plugins/runner/osm/writers/OsmRelationTagWriter.h (line 28) <https://git.reviewboard.kde.org/r/124096/#comment55855> please use a const reference for id, same at similar places src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp (line 44) <https://git.reviewboard.kde.org/r/124096/#comment55856> typo src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp (line 66) <https://git.reviewboard.kde.org/r/124096/#comment55857> please use const references for members and id - Dennis Nienhüser On Juni 14, 2015, 8:33 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124096/ > ----------------------------------------------------------- > > (Updated Juni 14, 2015, 8:33 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Classes with static functions that make writing typical osm tags convenient ( > <node>, <way>, <relation>, <osm> ) > > > Diffs > ----- > > src/plugins/runner/osm/writers/OsmNodeTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmRelationTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmWayTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmWayTagWriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124096/diff/ > > > Testing > ------- > > No testing was done yet as these are just static functions, will taste in > later patches. > Compiles fine > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
