> On Juli 16, 2015, 8:07 nachm., Dennis Nienhüser wrote: > > Please check, diff 4 (which I commented) and the current one are identical. > > Marius Stanciu wrote: > yeah it's fine, i thought i mixed up some patches, then i reuploaded the > original. This one is fine :)
But it still has the issues I mentioned which are marked as fixed ;-) - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124096/#review82582 ----------------------------------------------------------- On Juli 15, 2015, 2:41 nachm., Marius Stanciu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124096/ > ----------------------------------------------------------- > > (Updated Juli 15, 2015, 2:41 nachm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Classes with static functions that make writing typical osm tags convenient ( > <node>, <way>, <relation>, <osm> ) > > > Diffs > ----- > > src/plugins/runner/osm/writers/OsmNodeTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmRelationTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmTagWriter.cpp PRE-CREATION > src/plugins/runner/osm/writers/OsmWayTagWriter.h PRE-CREATION > src/plugins/runner/osm/writers/OsmWayTagWriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124096/diff/ > > > Testing > ------- > > No testing was done yet as these are just static functions, will taste in > later patches. > Compiles fine > > > Thanks, > > Marius Stanciu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
