> On June 25, 2015, 7:40 p.m., Dennis Nienhüser wrote: > > src/lib/marble/MergedLayerDecorator.cpp, line 234 > > <https://git.reviewboard.kde.org/r/124182/diff/1/?file=381411#file381411line234> > > > > could also be implemented like this: > > > > bool const hasQuad = overlay->latLonQuad().isValid(); > > GeoDataLatLonBox const overlayLatLonBox = hasQuad ? > > overlay->latLonQuad().latLonAltBox() : overlay->latLonBox(); > > > > The benefit is to avoid computing overlay->latLonBox() in any case and > > keeping the const qualifier of overlayLatLonBox. > > > > Is it intentional that the Alt part of the box is stripped away due to > > the conversion?
We'll pick this up again once we start the rendering part. - Ana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/#review81756 ----------------------------------------------------------- On July 1, 2015, 5:51 p.m., Ana Badescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124182/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:51 p.m.) > > > Review request for Marble and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > Work in progress > > > Diffs > ----- > > src/lib/marble/MergedLayerDecorator.cpp 47ac63e > src/lib/marble/geodata/data/GeoDataLatLonQuad.h d38848a > src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp 6cb9748 > src/lib/marble/geodata/handlers/kml/KmlLatLonQuadTagHandler.cpp 57b3465 > tests/TestLatLonQuad.cpp 077fe4d > > Diff: https://git.reviewboard.kde.org/r/124182/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > 0001_Implement_latLonQuad_tag.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/26/9e46bc90-031f-4f44-9723-d52ed15287e7__0001_Implement_latLonQuad_tag.diff > 0001_Implement_latLonQuad_tag.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/3f5a935c-555d-4204-9ea4-24c81b850fc8__0001_Implement_latLonQuad_tag.diff > 0002_Implement_latLonQuad_tag_test.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/8bed5582-7608-4508-9f96-70460b86e728__0002_Implement_latLonQuad_tag_test.diff > > > Thanks, > > Ana Badescu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
