> On June 29, 2015, 2:16 p.m., Torsten Rahn wrote: > > Hi Ana, > > > > Thanks for your review request on the tests. > > Some thoughts on improvements: > > - Why did you attach the tests as a diff instead of adding them to the > > review request? :-) ? > > - Please add some more corner cases for the test (it's most likely that > > those fail): e.g. > > * A Quad that covers the dateline/antimeridian > > Any more ideas on what to test for? :-) > > Dennis Nienhüser wrote: > If you did more than one commit and want to create a single patch from > it, this should work: > git diff origin/master > /tmp/latLonQuad.diff
I didn't know how diffs stack on eachother on the reviewboard. I'll use commits in the future, to easier track changes, great suggestion! - Ana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124182/#review81867 ----------------------------------------------------------- On July 1, 2015, 5:51 p.m., Ana Badescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124182/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 5:51 p.m.) > > > Review request for Marble and Torsten Rahn. > > > Repository: marble > > > Description > ------- > > Work in progress > > > Diffs > ----- > > src/lib/marble/MergedLayerDecorator.cpp 47ac63e > src/lib/marble/geodata/data/GeoDataLatLonQuad.h d38848a > src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp 6cb9748 > src/lib/marble/geodata/handlers/kml/KmlLatLonQuadTagHandler.cpp 57b3465 > tests/TestLatLonQuad.cpp 077fe4d > > Diff: https://git.reviewboard.kde.org/r/124182/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > 0001_Implement_latLonQuad_tag.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/26/9e46bc90-031f-4f44-9723-d52ed15287e7__0001_Implement_latLonQuad_tag.diff > 0001_Implement_latLonQuad_tag.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/3f5a935c-555d-4204-9ea4-24c81b850fc8__0001_Implement_latLonQuad_tag.diff > 0002_Implement_latLonQuad_tag_test.diff > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/29/8bed5582-7608-4508-9f96-70460b86e728__0002_Implement_latLonQuad_tag_test.diff > > > Thanks, > > Ana Badescu > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
