----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124703/#review83738 -----------------------------------------------------------
Great, I was hoping this would be doable with clean code like this :) src/apps/marble-maps/TextToSpeechClient.h (line 25) <https://git.reviewboard.kde.org/r/124703/#comment57949> const QString &, same below src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java (line 19) <https://git.reviewboard.kde.org/r/124703/#comment57953> Is this supposed to be a singleton? Then it's not implemented safely, m_instance would be overwritten when the next TextToSpeechClient() is created. Here's some discussion how to create a singleton in Java: http://stackoverflow.com/questions/70689/what-is-an-efficient-way-to-implement-a-singleton-pattern-in-java src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java (line 36) <https://git.reviewboard.kde.org/r/124703/#comment57951> please remove src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java (line 42) <https://git.reviewboard.kde.org/r/124703/#comment57952> else print a warning to the shell / some log? - Dennis Nienhüser On Aug. 12, 2015, 2:02 vorm., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124703/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 2:02 vorm.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Text to speech can be used from qml like this: > textToSpeechClient.readText("Have a pleasant journey!"); > > > Diffs > ----- > > src/apps/marble-maps/TextToSpeechClient.h PRE-CREATION > src/apps/marble-maps/TextToSpeechClient.cpp PRE-CREATION > src/apps/marble-maps/main.cpp e1a74d6 > src/apps/marble-maps/package/AndroidManifest.xml dfb3061 > > src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124703/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
