> On Aug. 12, 2015, 1:13 p.m., Dennis Nienhüser wrote: > > src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java, > > line 19 > > <https://git.reviewboard.kde.org/r/124703/diff/1/?file=393526#file393526line19> > > > > Is this supposed to be a singleton? Then it's not implemented safely, > > m_instance would be overwritten when the next TextToSpeechClient() is > > created. > > Here's some discussion how to create a singleton in Java: > > http://stackoverflow.com/questions/70689/what-is-an-efficient-way-to-implement-a-singleton-pattern-in-java
If the enum variant mentioned in the link is problematic to implement, number 2) in http://codebalance.blogspot.de/2010/08/singleton-pattern-and-beyond.html seems a good alternative. - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124703/#review83738 ----------------------------------------------------------- On Aug. 12, 2015, 2:02 a.m., Gábor Péterffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124703/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 2:02 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > Text to speech can be used from qml like this: > textToSpeechClient.readText("Have a pleasant journey!"); > > > Diffs > ----- > > src/apps/marble-maps/TextToSpeechClient.h PRE-CREATION > src/apps/marble-maps/TextToSpeechClient.cpp PRE-CREATION > src/apps/marble-maps/main.cpp e1a74d6 > src/apps/marble-maps/package/AndroidManifest.xml dfb3061 > > src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124703/diff/ > > > Testing > ------- > > > Thanks, > > Gábor Péterffy > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
