----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124834/ -----------------------------------------------------------
Review request for Marble. Repository: marble Description ------- * There is a `zoomAt()` and a `zoomBy()` method in `MarbleAbstractPresenter`, so I've created a new `void MarbleAbstractPresenter::zoomAtBy(const QPoint &pos, int zoomStep)` method to combine the functionality of both. This new method is used in `MarbleDefaultInputHandler::handleWheel()`, but only if the map theme is `Openstreetmap`. * The new `Empty` map theme is a simple 50 line .dgml file, with just a single empty geodata layer. Calling it `Empty` is a good idea or should we use another name for it? Diffs ----- data/CMakeLists.txt 0a9c6e5 src/lib/marble/MarbleAbstractPresenter.h 7fb203d src/lib/marble/MarbleAbstractPresenter.cpp acaab22 src/lib/marble/MarbleInputHandler.cpp 393ce42 Diff: https://git.reviewboard.kde.org/r/124834/diff/ Testing ------- A small video demonstrating these two new features: https://www.youtube.com/watch?v=jMorQDwr2A8 File Attachments ---------------- empty-preview.png https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/132190ff-11f7-45a2-b361-266f6aa752fc__empty-preview.png empty.dgml https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/39c98dcb-b35f-421a-bcf9-c3f95f15cfe3__empty.dgml Thanks, Dávid Kolozsvári
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
