> On Aug. 20, 2015, 8:24 p.m., Torsten Rahn wrote: > > src/lib/marble/MarbleAbstractPresenter.cpp, line 259 > > <https://git.reviewboard.kde.org/r/124834/diff/1/?file=396571#file396571line259> > > > > I think we should make this a mode. > > We have a tag <discrete> false </discrete> in the map themes. Currently > > it's not used at all. the idea however had been that only setting it to > > true (which makes sense for openstreetmap) would result in the preferred > > zoom levels you implemented. > > > > I see an additional problem: right now your implementation is not > > backwards compatible in terms of behavior. So maybe it would be a good idea > > to introduce a discreteZoomLevel property that possibly gets set via the > > map theme. Hm ....
I don't really understand the issue about the backward compatibility and discrete zoom level, could you explain it in a little more detail? :) - Dávid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124834/#review84116 ----------------------------------------------------------- On Aug. 20, 2015, 4:54 a.m., Dávid Kolozsvári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124834/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 4:54 a.m.) > > > Review request for Marble. > > > Repository: marble > > > Description > ------- > > * There is a `zoomAt()` and a `zoomBy()` method in `MarbleAbstractPresenter`, > so I've created a new `void MarbleAbstractPresenter::zoomAtBy(const QPoint > &pos, int zoomStep)` method to combine the functionality of both. This new > method is used in `MarbleDefaultInputHandler::handleWheel()`, but only if the > map theme is `Openstreetmap`. > * The new `Empty` map theme is a simple 50 line .dgml file, with just a > single empty geodata layer. Calling it `Empty` is a good idea or should we > use another name for it? > > > Diffs > ----- > > data/CMakeLists.txt 0a9c6e5 > src/lib/marble/MarbleAbstractPresenter.h 7fb203d > src/lib/marble/MarbleAbstractPresenter.cpp acaab22 > src/lib/marble/MarbleInputHandler.cpp 393ce42 > > Diff: https://git.reviewboard.kde.org/r/124834/diff/ > > > Testing > ------- > > A small video demonstrating these two new features: > https://www.youtube.com/watch?v=jMorQDwr2A8 > > > File Attachments > ---------------- > > empty-preview.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/132190ff-11f7-45a2-b361-266f6aa752fc__empty-preview.png > empty.dgml > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/39c98dcb-b35f-421a-bcf9-c3f95f15cfe3__empty.dgml > > > Thanks, > > Dávid Kolozsvári > >
_______________________________________________ Marble-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/marble-devel
