>>>>> "John" == John Hunter <[EMAIL PROTECTED]> writes:

>>>>> "Eric" == Eric Firing <[EMAIL PROTECTED]> writes:
    Eric> arrow 1/50th the width of the plot.  Change the window
    Eric> width, and the arrow length changes along with it.  Zoom,
    Eric> and it does not change, however.  In all cases, the arrow
    Eric> direction remains constant, regardless of window or view
    Eric> limit manipulations.  (This is all because of John's
    Eric> transform magic--it is a little hard to understand at first,
    Eric> but it certainly provides wonderful functionality.)

    John> Hey someone said something nice about transforms!

    John> Eric, I haven't had a chance to try this code out but I did
    John> read through it and it looks very nice.  A small comment:
    John> fig.dpi is already a Value, so I don't think you want

    John> + elif self.units == 'inches': + dpi = ax.figure.dpi.get() +
    John> dx = T.Value(dpi)

    John> because that is copy semantics and you probably want
    John> reference semantics

    John> + elif self.units == 'inches': + dx = ax.figure.dpi

    John> That way if someone changes the figure dpi.  Or maybe I'm
    John> missing something and you really want copy.

    John>   fig.dpi.set(72.)

    John> all of your transforms are automagically updated.

OK, let me try again.  I added the "maybe I'm missing something"
sentence after reading through my post in the wrong place and it
totally garbled the meaning.  What I meant to say was

A small comment: fig.dpi is already a Value, so I don't think you want

+            elif self.units == 'inches':
+                dpi = ax.figure.dpi.get()
+                dx = T.Value(dpi)

because that is copy semantics and you probably want reference
semantics

+            elif self.units == 'inches':
+                dx = ax.figure.dpi

That way if someone changes the figure dpi

  fig.dpi.set(72.)

all of your transforms are automagically updated.  Or maybe I'm missing
something and you really want copy.



JDH


_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to