jason-s...@creativetrax.com wrote:
> Here are a few patches that we in Sage have been applying to our version 
> of matplotlib.  I'm wondering if some or all of these might be 
> incorporated into matplotlib, or if not, if you could comment on these 
> patches.  I've updated the following diffs to be against 0.99.0.  I've 
> separated the patches with a bunch of dashes.

Jason,

I have committed versions of all but the third to the v0.99 branch. 
Please check svn r7442-7444.  I also propagated them to the trunk.  If 
you have any questions or reservations about the modifications I made, 
please raise them!  (The modification to #1 is because blanket "except:" 
is highly discouraged in mpl, and seemed unnecessary here.  The 
modification to #4 is for code clarity, to make it even more obvious 
that the empty string is used as the version only in case of an exception.)

I did not commit #3.  Apart from my lack of c++ expertise, I don't know 
how to implement it so that it takes effect only in the Solaris case. 
Therefore I am leaving this for John; or maybe he will pass it to Mike 
when he comes back from vacation.  Below, I am deleting all but #3, to 
make it easier for John to see what we are talking about.

Eric

> ---------------------------------------------------------------------------------------------------------------------------------------
> ttconv/pprdrv_tt2.cpp: This patch is *only* applied when `uname` = 
> "SunOS".  The comment is: Copy patched version of pprdrv_tt2.cpp for 
> Solaris 10 that builds with gcc 4.3.2.
> 
> 
> --- src/ttconv/pprdrv_tt2.cpp    2009-08-01 12:15:15.000000000 -0700
> +++ patches/pprdrv_tt2.cpp    2009-08-08 23:33:24.000000000 -0700
> @@ -104,7 +104,8 @@
>      {                /* have a log of points. */
>      if(stack_depth == 0)
>          {
> -            stream.put_char('{');
> +            //  Note the below is a hack to make it compile on Solaris 
> 10 with gcc 4.3.2
> +            stream.puts("{");
>              stack_depth=1;
>              }
>  
> 
> 
> --------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Matplotlib-devel mailing list
Matplotlib-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/matplotlib-devel

Reply via email to