On Tue, Aug 11, 2009 at 5:02 PM, Ariel Rokem<aro...@berkeley.edu> wrote:
> here is a suggested patch for mlab's cohere_pairs function. The old version > was broken, due to some outdated code. Thanks Ariel for the patch. Could you explain your patch in words -- what was broken before and how you fixed it. Also, while your patch is particularly simple, since it is just a single function replacement, we encourage people to submit svn diffs against HEAD or the branch they are patching. It just makes life simpler for us, since we (fortunately) get a lot of contributions. I strongly encourage people to include a complete, free-standing example that I can run unmodified which shows the undesired behavior pre-patch and the desired behavior post-patch, with a clear verbal of what to look for. I wrote this function 5 years ago, and while I remember it pretty well, I will not be as familiar with it after such a long hiatus as you are now. http://matplotlib.sourceforge.net/faq/howto_faq.html#contributing-howto JDH ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
