On Tue, Aug 11, 2009 at 7:29 PM, Ariel Rokem<aro...@berkeley.edu> wrote: > ASR:matplotlib arokem$ make build_os105 > make: *** No rule to make target `build_os105'. Stop.
Typo: John said: make build_osx105 Note the extra 'x'. By the way John, in this particular case, I don't think the change warrants a before/after example, because the before case is "it doesn't run" :) The code today makes calls to Numeric routines like typecode() that simply don't exist anymore, so it's totally broken: In [1]: x = rand(512,3) In [2]: ij = [(0,1),(1,2)] In [3]: mlab.cohere_pairs(x,ij) --------------------------------------------------------------------------- NameError Traceback (most recent call last) /home/installers/src/scipy/matplotlib/<ipython console> in <module>() /home/fperez/usr/opt/lib/python2.6/site-packages/matplotlib/mlab.pyc in cohere_pairs(X, ij, NFFT, Fs, detrend, window, noverlap, preferSpeedOverMemory, progressCallback, returnPxx) 597 windowVals = window 598 else: --> 599 windowVals = window(np.ones((NFFT,), typecode(X))) 600 ind = range(0, numRows-NFFT+1, NFFT-noverlap) 601 numSlices = len(ind) NameError: global name 'typecode' is not defined The fixes Ariel is sending are strictly confined to making the code run again, by using the equivalent numpy calls: In [1]: x = rand(512,3) In [2]: ij = [(0,1),(1,2)] In [3]: mlab.cohere_pairs(x,ij) Out[3]: ({(0, 1): 0.68070570340049885, (1, 2): 0.70577163603522997}, {(0, 1): -0.007568280470951907, (1, 2): 0.0027428217481150026}, array([ 0. , 0.0078, 0.0156, 0.0234, 0.0312, 0.0391, 0.0469, 0.0547, 0.0625, 0.0703, 0.0781, 0.0859, 0.0938, 0.1016, 0.1094, 0.1172, 0.125 , 0.1328, 0.1406, 0.1484, 0.1562, 0.1641, 0.1719, 0.1797, 0.1875, 0.1953, 0.2031, 0.2109, 0.2188, 0.2266, 0.2344, 0.2422, 0.25 , 0.2578, 0.2656, 0.2734, 0.2812, 0.2891, 0.2969, 0.3047, 0.3125, 0.3203, 0.3281, 0.3359, 0.3438, 0.3516, 0.3594, 0.3672, 0.375 , 0.3828, 0.3906, 0.3984, 0.4062, 0.4141, 0.4219, 0.4297, 0.4375, 0.4453, 0.4531, 0.4609, 0.4688, 0.4766, 0.4844, 0.4922, 0.5 , 0.5078, 0.5156, 0.5234, 0.5312, 0.5391, 0.5469, 0.5547, 0.5625, 0.5703, 0.5781, 0.5859, 0.5938, 0.6016, 0.6094, 0.6172, 0.625 , 0.6328, 0.6406, 0.6484, 0.6562, 0.6641, 0.6719, 0.6797, 0.6875, 0.6953, 0.7031, 0.7109, 0.7188, 0.7266, 0.7344, 0.7422, 0.75 , 0.7578, 0.7656, 0.7734, 0.7812, 0.7891, 0.7969, 0.8047, 0.8125, 0.8203, 0.8281, 0.8359, 0.8438, 0.8516, 0.8594, 0.8672, 0.875 , 0.8828, 0.8906, 0.8984, 0.9062, 0.9141, 0.9219, 0.9297, 0.9375, 0.9453, 0.9531, 0.9609, 0.9688, 0.9766, 0.9844, 0.9922, 1. ])) Ariel, if you are still struggling with the binary build, since your changes are confined to a pure python file, you can submit the patch by simply running: - svn udpate - modify in-place mlab.py with your version of cohere_pairs - svn diff > mlab_cohere_pairs.diff You may want to watch out for the fact that the docstring in your version doesn't start with u""" This means the string is Unicode. It seems mpl has been unicode-ified so it's best to fix this before you generate the diff. This is why John encourages the diff to be made against HEAD, so these little things can be easily spotted. By doing this, you'll notice small changes in formatting you might not have meant to introduce, so it lets you clean up the contribution before sending it so it really only changes what you intended to. Cheers, f ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel