On 6/10/10 7:01 AM, Jason Grout wrote:
In http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg05423.html, I reported a patch that Sage uses for matplotlib on Solaris. Notice below that only one line is changed.--------------------------------------------------------------------------------------------------------------------------------------- ttconv/pprdrv_tt2.cpp: This patch is *only* applied when `uname` = "SunOS". The comment is: Copy patched version of pprdrv_tt2.cpp for Solaris 10 that builds with gcc 4.3.2. --- src/ttconv/pprdrv_tt2.cpp 2009-08-01 12:15:15.000000000 -0700 +++ patches/pprdrv_tt2.cpp 2009-08-08 23:33:24.000000000 -0700 @@ -104,7 +104,8 @@ { /* have a log of points. */ if(stack_depth == 0) { - stream.put_char('{'); + // Note the below is a hack to make it compile on Solaris 10 with gcc 4.3.2 + stream.puts("{"); stack_depth=1; }In http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg05428.html, John said he'd look at it, but also asked for a platform macro for Solaris. I'm not sure what was done about it since then. I notice that the 0.99.3 release has the original code (i.e., no patch has been applied). John (or anyone), if you have time, could you take a look at this?I'm CCing Dave Kirkby, who is a person in the Sage community that has been working quite a bit on getting things to work on Solaris. He might have an idea of a good C macro for detecting when we are on Solaris.
I see that http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg04947.html is a related message which discusses compiling on Solaris and the put_char method. In fact, I think the issue may be fixed from the discussion in that message, and our patch is unnecessary now. I'm preparing a new matplotlib package for Sage without our patch above which we will test on Solaris.
Jason -- Jason Grout
------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
