On Fri, Feb 25, 2011 at 1:48 PM, Darren Dale <dsdal...@gmail.com> wrote: > On Fri, Feb 25, 2011 at 2:43 PM, Ryan May <rma...@gmail.com> wrote: >> On Fri, Feb 25, 2011 at 1:11 PM, Darren Dale <dsdal...@gmail.com> wrote: >>> On Fri, Feb 25, 2011 at 1:45 PM, Benjamin Root <ben.r...@ou.edu> wrote: >>>> Ok, I am still learning quite a bit about git, please bear with me. >>>> >>>> I am having difficulty completing a pull request that I opened. >>> >>> In general, I don't think we should close our own pull requests. It >>> short-circuits the review process. >> >> Agreed in principle. However, do we as devs want to get/give reviews >> on every change that fixes typos in the docs or fixes stupid bugs in >> examples? I think there's a point of diminishing returns. > > I agree. Hence the "in general" qualification. >
Sorry. Glossed over that and took you mentioning it in this context as objecting to self-merging this particular set of simple changes. Ryan -- Ryan May Graduate Research Assistant School of Meteorology University of Oklahoma ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
